Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecated setMockMethodCallHandler to TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler #1749

Closed
wants to merge 3 commits into from
Closed

Change deprecated setMockMethodCallHandler to TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler #1749

wants to merge 3 commits into from

Conversation

natsuk4ze
Copy link
Contributor

Changed deprecated setMockMethodCallHandler in experimental\federated_plugin\federated_plugin

to fix error : 'setMockMethodCallHandler' is deprecated and shouldn't be used. Use tester.binding.defaultBinaryMessenger.setMockMethodCallHandler or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler instead. Pass the channel as the first argument. This feature was deprecated after v3.9.0-19.0.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use in PR #1740

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@domesticmouse domesticmouse self-requested a review April 27, 2023 11:06
domesticmouse
domesticmouse approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass

@natsuk4ze
Copy link
Contributor Author

I'm going to go modify the code a bit.

@domesticmouse
Copy link
Contributor

I'm going to go modify the code a bit.

Is this change only for beta and master?

@natsuk4ze
Copy link
Contributor Author

Is this change only for beta and master?

I'm a newbie so I'm not sure what your question means 😢I'm working on a branch forked from the master branch. I'm trying to fix a few things that didn't pass tests.

@natsuk4ze
Copy link
Contributor Author

I guess it means that the test is failing only in flutter beta and master. Either way I have made a few changes and need to see how this test goes.

@domesticmouse
Copy link
Contributor

Is this change only for beta and master?

I'm a newbie so I'm not sure what your question means 😢I'm working on a branch forked from the master branch. I'm trying to fix a few things that didn't pass tests.

I think you'll have a saner time if you try developing a fix on beta branch. I suspect master is starting to take on breaking changes that won't surface in the next stable release, which is what I'm aiming at stabilising on for this repository.

@natsuk4ze
Copy link
Contributor Author

@domesticmouse I will close this and the #1740 PR once and start over with a new branch from the beta branch. Is that OK?
And are there fewer test failures in the beta branch?

@domesticmouse
Copy link
Contributor

@domesticmouse I will close this and the #1740 PR once and start over with a new branch from the beta branch. Is that OK? And are there fewer test failures in the beta branch?

The beta branch is going to be landed when Flutter 3.10 goes stable. It's WIP until then.

I'll create a new PR with the changes required to fix federated_plugin.

@domesticmouse domesticmouse mentioned this pull request May 5, 2023
Merged
5 tasks
domesticmouse added a commit that referenced this pull request May 6, 2023
@domesticmouse
Fixup experimental/federated_plugin (#1776)
b703f1f 
Replaces #1749

FYI @negotoyolo

## Pre-launch Checklist

- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [x] I read the [Contributors Guide].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].

<!-- Links -->
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[CLA]: https://cla.developers.google.com/
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Contributors Guide]:
https://github.com/flutter/samples/blob/main/CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natsuk4ze @domesticmouse